Open
Conversation
When extra attributes are given to upnp:albumArtURI, the "main" value of albumArtURI is assigned to '_' inside a dict. This seems to happen for tracks played over DLNA. Handle this case so albumArtURI and consequently albumArtURL is parsed correctly and doesn't error out.
In case a parsing error occurs attempting to create albumArtURL, just log the problem to console rather than throwing an exception and failing out.
kcghost
force-pushed
the
fix-albumarturl-errors
branch
from
4484666 to
d8dfa06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #516. That is, unless there is another albumArtURI parsing error root cause besides the one I found. I had a DLNA played track on my network that caused this error in a very reproducible manner.
The first change handles the error itself, the other is a change to swallow an error in CurrentTrack if a different parsing error occurs (make it do its best rather than fail out). I imagine whether you wish to accept the second depends largely on your philosophy. I just know that the way sonos-web uses this project, all of sonos-web becomes unusable if this error occurs on any sonos host. I would rather it fail to display the albumart than fail to do anything at all.